[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 1/3] docs, conf, schema: add support for shmem device



Hi,

On Thu, Sep 25, 2014 at 03:37:46PM +0200, Michal Privoznik wrote:
> On 25.09.2014 11:45, Martin Kletzander wrote:
> [...]
> 
> Where do these restrictions come from? If they're result of qemu
> implementation, than they should be checked in 3/3. If other HV learned
> shmem these limitations may not apply to it. Or is it a kernel thing that
> only areas with 1MB granularity can be mapped? Moreover, if such granularity
> is required, does it makes sense to store the size in bytes?
> 

It's ivshmem... The problem is that ivshmem predominantly thinks that
any size argument without a suffix like 'g/G' or 'm/M' is in
megabytes. I believe this is nice, but it would be nicer to have a
'k/K' suffix so that we could tell ivshmem that we want the size in
kilobytes... Maybe even a 'b' suffix for bytes.

Do you guys see any value in this? If yes, I will cook a patch ASAP,
so we might as well remove this check from the QEMU parts...

But yes, this check is definitely not needed here.

Thanks,
Levente.

Attachment: pgp5KhKrtG0Vg.pgp
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]