[libvirt] [PATCH] virNodeAllocPages: Disallow RO connection

Michal Privoznik mprivozn at redhat.com
Thu Sep 25 15:13:45 UTC 2014


Due to a missing check the API can be successfully called even if
the connection is ReadOnly. Fortunately, the API hasn't been
released yet, so there's no need for a CVE.

Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
---
 src/libvirt.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/libvirt.c b/src/libvirt.c
index 388c040..245c373 100644
--- a/src/libvirt.c
+++ b/src/libvirt.c
@@ -21893,6 +21893,7 @@ virNodeAllocPages(virConnectPtr conn,
     virResetLastError();
 
     virCheckConnectReturn(conn, -1);
+    virCheckReadOnlyGoto(conn->flags, error);
     virCheckNonZeroArgGoto(npages, error);
     virCheckNonNullArgGoto(pageSizes, error);
     virCheckNonNullArgGoto(pageCounts, error);
-- 
1.8.5.5




More information about the libvir-list mailing list