[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 3/3] qemu: Build command line for ivshmem device



On Thu, Sep 25, 2014 at 03:37:42PM +0200, Michal Privoznik wrote:
On 25.09.2014 11:45, Martin Kletzander wrote:
This patch implements support for the ivshmem device in QEMU.

Signed-off-by: Maxime Leroy <maxime leroy 6wind com>
Signed-off-by: Martin Kletzander <mkletzan redhat com>
---
  src/qemu/qemu_command.c  | 118 ++++++++++++++++++++++++++++++++++++++++++++++-
  src/qemu/qemu_command.h  |   1 +
  tests/qemuxml2argvtest.c |   3 ++
  3 files changed, 121 insertions(+), 1 deletion(-)

This is the correct place to introduce .args. It's okay to introduce
.xml in the patch that adds XML parsing/formatting as the .xml can be
tested straight away.


I know, I probably used '-a' for 'git commit' when creating a fixup
for 1/3 and that pulled the .args changes in.  I'll push that file as
a part of this commit of course.

Thanks for he review,
Martin

Attachment: signature.asc
Description: Digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]