[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] qemuPrepareNVRAM: Save domain after NVRAM path generation



On Thu, Sep 25, 2014 at 03:00:06PM +0200, Michal Privoznik wrote:
On a domain startup, the variable store path is generated if needed.
The path is intended to be generated only once. However, the updated
domain definition is not saved into config dir rather than state XML

the 'is not' confused me in here.  Did you mean s/not // by any chance?

only. So later, whenever the domain is destroyed and the daemon is
restarted, the generated path is forgotten and the file may be left
behind on virDomainUndefine() call.


And if you did really mean "the updated domain definition is saved
into config dir rather than state XML only", why isn't that done when
the domain is defined (in PostParse() for example) like address
assignment, etc.?

Signed-off-by: Michal Privoznik <mprivozn redhat com>
---
src/qemu/qemu_process.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index dddca35..1b8931e 100644
--- a/src/qemu/qemu_process.c
+++ b/src/qemu/qemu_process.c
@@ -3876,6 +3876,9 @@ qemuPrepareNVRAM(virQEMUDriverConfigPtr cfg,
            goto cleanup;

        generated = true;
+
+        if (virDomainSaveConfig(cfg->configDir, def) < 0)
+            goto cleanup;
    }

    if (!virFileExists(loader->nvram)) {
--
1.8.5.5

--
libvir-list mailing list
libvir-list redhat com
https://www.redhat.com/mailman/listinfo/libvir-list

Attachment: signature.asc
Description: Digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]