[libvirt] [PATCH v3 3/3] qemu: Build command line for ivshmem device

[Martin Kletzander]

On Fri, Sep 26, 2014 at 02:47:48PM +0200, Levente Kurusa wrote:
>Hi,
>
>On Fri, Sep 26, 2014 at 12:43:08PM +0200, Martin Kletzander wrote:
>> This patch implements support for the ivshmem device in QEMU.
>>
>> Signed-off-by: Maxime Leroy <maxime.leroy at 6wind.com>
>> Signed-off-by: Martin Kletzander <mkletzan at redhat.com>
>> ---
>>
>> -
>
>Nitpicks shall follow! :)
>
>What's this?
>
>>  /*
>>   * This method takes a string representing a QEMU command line ARGV set
>>   * optionally prefixed by a list of environment variables. It then tries
>> diff --git a/src/qemu/qemu_command.h b/src/qemu/qemu_command.h
>> index aa40c9e..5083223 100644
>> --- a/src/qemu/qemu_command.h
>> +++ b/src/qemu/qemu_command.h
>> @@ -131,6 +131,7 @@ char *qemuBuildDriveDevStr(virDomainDefPtr def,
>>  char *qemuBuildFSDevStr(virDomainDefPtr domainDef,
>>                          virDomainFSDefPtr fs,
>>                          virQEMUCapsPtr qemuCaps);
>> +
>
>And this whole hunk?
>

Good catches, both removed, thanks ;)

Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140926/8fc0e705/attachment-0001.sig>