[libvirt] [PATCH v2 0/6] storage: handle scsi/iscsi error paths better

John Ferlan jferlan at redhat.com
Wed Apr 1 17:29:05 UTC 2015

v1 here:


1/6: Removed the virGetLastError() == NULL check
2/6: New - reading more closely showed an error path without a goto
3/6: New - Adjust return for virStorageBackendSCSINewLun to be able
           to differentiate real error vs. deciding to return because
           a stable path could not be determined
4/6: New - Found an unused variable in processLU
5/6: Adjust the logic to return -1 for "real" errors and -2 for errors
     that are "recoverable". Removed the need for goto cleanup.
6/6: Add check for non-existent stable path at startup (and fail). Add
     check during refresh for a found non standard stable path that returns
     no volumes in the pool
John Ferlan (6):
  iscsi: Use error message from virStorageBackendSCSIFindLUs
  iscsi: Fix exit path for virStorageBackendISCSIFindLUs failure
  scsi: Adjust return value for virStorageBackendSCSINewLun
  scsi: Remove unused 'type_path' in processLU
  scsi: Adjust return values from processLU
  iscsi: Add checks for non standard stable target.path

 src/storage/storage_backend_iscsi.c | 33 ++++++++++++++++-----
 src/storage/storage_backend_scsi.c  | 59 ++++++++++++++++++++++++-------------
 2 files changed, 64 insertions(+), 28 deletions(-)


More information about the libvir-list mailing list