[libvirt] [PATCH v2 2/6] iscsi: Fix exit path for virStorageBackendISCSIFindLUs failure

Ján Tomko jtomko at redhat.com
Thu Apr 2 10:32:25 UTC 2015


On Wed, Apr 01, 2015 at 01:29:07PM -0400, John Ferlan wrote:
> If the call to virStorageBackendISCSIGetHostNumber failed, we set
> retval = -1, but yet still called virStorageBackendSCSIFindLUs.
> Need to add a goto cleanup - while at it, adjust the logic to
> initialize retval to -1 and only changed to 0 (zero) on success.
> 
> Signed-off-by: John Ferlan <jferlan at redhat.com>
> ---
>  src/storage/storage_backend_iscsi.c | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
> 

ACK

Jan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150402/3d9e9c3f/attachment-0001.sig>


More information about the libvir-list mailing list