[libvirt] [PATCH 1/6] conf: Introduce virStoragePoolDefFormatBuf
Erik Skultety
eskultet at redhat.com
Fri Apr 3 08:31:14 UTC 2015
>
> ACK with one nit:
>
>> diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c
>> index b070448..a8e9876 100644
>> --- a/src/conf/storage_conf.c
>> +++ b/src/conf/storage_conf.c
>> @@ -1150,76 +1150,90 @@ virStoragePoolSourceFormat(virBufferPtr buf,
>
> --- 8< ---
>
>> - virBufferAdjustIndent(&buf, -2);
>> - virBufferAddLit(&buf, "</pool>\n");
>> + virBufferAdjustIndent(buf, -2);
>> + virBufferAddLit(buf, "</pool>\n");
>> +
>> + return 0;
>> +
>> + error:
>> + return -1;
>
> The error label is not necessary - just return -1; directly (unless you
> plan to add some cleanup code there in the near future).
>
> Jan
>
Thanks, now pushed.
Erik
More information about the libvir-list
mailing list