[libvirt] [PATCH] conf: fix memleak in qemuRestoreCgroupState

lhuang lhuang at redhat.com
Wed Apr 8 10:09:50 UTC 2015


On 04/08/2015 06:00 PM, Ján Tomko wrote:
> The subject prefix is incorrect - this is not in src/conf.
>
> I just removed it completely, there's still a reference to qemu driver
> in the function name.

Oh, that is a mistake, i can't remember why i chose "conf" as this 
commit subject prefix (maybe i was so hungry at that time :-P ).

Thanks a lot for your review and help.

> On Wed, Apr 08, 2015 at 02:25:59PM +0800, Luyao Huang wrote:
>>   131,088 bytes in 16 blocks are definitely lost in loss record 2,174 of 2,176
>>      at 0x4C29BFD: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
>>      by 0x4C2BACB: realloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
>>      by 0x52A026F: virReallocN (viralloc.c:245)
>>      by 0x52BFCB5: saferead_lim (virfile.c:1268)
>>      by 0x52C00EF: virFileReadLimFD (virfile.c:1328)
>>      by 0x52C019A: virFileReadAll (virfile.c:1351)
>>      by 0x52A5D4F: virCgroupGetValueStr (vircgroup.c:763)
>>      by 0x1DDA0DA3: qemuRestoreCgroupState (qemu_cgroup.c:805)
>>      by 0x1DDA0DA3: qemuConnectCgroup (qemu_cgroup.c:857)
>>      by 0x1DDB7BA1: qemuProcessReconnect (qemu_process.c:3694)
>>      by 0x52FD171: virThreadHelper (virthread.c:206)
>>      by 0x82B8DF4: start_thread (pthread_create.c:308)
>>      by 0x85C31AC: clone (clone.S:113)
>>
>> Signed-off-by: Luyao Huang <lhuang at redhat.com>
>> ---
>>   src/qemu/qemu_cgroup.c | 2 ++
>>   1 file changed, 2 insertions(+)
> ACK and pushed.
>
> Jan




More information about the libvir-list mailing list