[libvirt] [PATCH] qemu: Use 'idx' instead of 'index' for variable name
John Ferlan
jferlan at redhat.com
Tue Apr 14 11:40:30 UTC 2015
On 04/14/2015 07:24 AM, Daniel P. Berrange wrote:
> On Tue, Apr 14, 2015 at 07:19:17AM -0400, John Ferlan wrote:
>>
>>
>>>
>>
>> I thought of that too, but it picked up a few comments too
>>
>> ...
>> src/libvirt-domain.c:11105: * "block.<num>.backingIndex" - unsigned int
>> giving the <backingStore> index,
>> ...
>> src/util/virnetdev.c:870: * @ifindex: Pointer to int where the index
>> will be written into
>
> How about changing the regex to
>
> (int|unsigned)\s*\*?index
>
> That'd probably have less false positives and still catch the common
> cases well enough
>
>
That worked! Thanks - regex's are still mostly a mystery
I've put together a series which I'll post shortly
John
More information about the libvir-list
mailing list