[libvirt] [PATCH 0/5] Prohibit use of 'index' for variable

[Martin Kletzander]

On Tue, Apr 14, 2015 at 07:54:56AM -0400, John Ferlan wrote:
>Given the recent Xen-devel build failure/issue - this series of patches
>will remove our uses of '[unsigned] int index' and then generate a rule
>for it
>
>John Ferlan (5):
>  qemu: Adjust the prototype to match the function
>  util: Use 'idx' instead of 'index'
>  snapshot: Change 'index' to 'idx'
>  nwfilter: Change 'index' to 'idx'
>  cfg: Disallow usage of 'index' as variable name
>

Works for me, the only left out index variable I've found out was the
one visible in 4/5 which is a struct anyway and extending the check
for that would (as you wrote earlier) cause a false positive in a
comment.  That could be changed, but isn't worth it, IMHO.

ACK series.

> cfg.mk                     | 5 +++++
> src/conf/nwfilter_params.c | 8 ++++----
> src/conf/nwfilter_params.h | 2 +-
> src/conf/snapshot_conf.c   | 6 +++---
> src/conf/snapshot_conf.h   | 2 +-
> src/qemu/qemu_conf.h       | 2 +-
> src/qemu/qemu_driver.c     | 4 ++--
> src/util/virnetdev.c       | 4 ++--
> 8 files changed, 19 insertions(+), 14 deletions(-)
>
>--
>2.1.0
>
>--
>libvir-list mailing list
>libvir-list at redhat.com
>https://www.redhat.com/mailman/listinfo/libvir-list
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150414/cc0bd325/attachment-0001.sig>