[libvirt] [PATCH 3/5] qemu: add QEMU_CAPS_MACHINE_VMPORT_OPT

Martin Kletzander mkletzan at redhat.com
Tue Apr 14 16:24:19 UTC 2015


On Tue, Apr 14, 2015 at 05:58:45PM +0200, Marc-André Lureau wrote:
>Hi
>
>On Tue, Apr 14, 2015 at 4:25 PM, Martin Kletzander <mkletzan at redhat.com>
>wrote:
>
>> Is this not exposed in any way in QEMU?  Do we really need to use this
>> (what we're trying to avoid)?
>>
>
>That works with the following change:
>

ACK with that squashed in, no need to resend it ;)

>diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
>index 768cef1..1b20a7f 100644
>--- a/src/qemu/qemu_capabilities.c
>+++ b/src/qemu/qemu_capabilities.c
>@@ -2510,6 +2510,7 @@ struct virQEMUCapsCommandLineProps {
>
> static struct virQEMUCapsCommandLineProps virQEMUCapsCommandLine[] = {
>     { "machine", "mem-merge", QEMU_CAPS_MEM_MERGE },
>+    { "machine", "vmport", QEMU_CAPS_MACHINE_VMPORT_OPT },
>     { "drive", "discard", QEMU_CAPS_DRIVE_DISCARD },
>     { "realtime", "mlock", QEMU_CAPS_MLOCK },
>     { "boot-opts", "strict", QEMU_CAPS_BOOT_STRICT },
>@@ -3243,10 +3244,6 @@ virQEMUCapsInitQMPMonitor(virQEMUCapsPtr qemuCaps,
>     if (qemuCaps->version >= 1003000)
>         virQEMUCapsSet(qemuCaps, QEMU_CAPS_MACHINE_USB_OPT);
>
>-    /* vmport option is supported v2.2.0 onwards */
>-    if (qemuCaps->version >= 2002000)
>-        virQEMUCapsSet(qemuCaps, QEMU_CAPS_MACHINE_VMPORT_OPT);
>
>I can resend this patch if necessary.
>
>
>--
>Marc-André Lureau
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150414/28b872f9/attachment-0001.sig>


More information about the libvir-list mailing list