[libvirt] [PATCH v2 1/8] storage: Refactor iSCSI Source matching

Peter Krempa pkrempa at redhat.com
Wed Apr 15 07:53:47 UTC 2015

On Mon, Apr 13, 2015 at 17:21:05 -0400, John Ferlan wrote:
> Create a separate iSCSI Source matching subroutine. Makes the calling
> code a bit cleaner as well as sets up for future patches which need to
> do better source hosts[0].name processing/checking.
> As part of the effort the logic will be inverted from a multi-level
> if statement to a series of single level checks for better readability
> and further separation
> Signed-off-by: John Ferlan <jferlan at redhat.com>
> Signed-off-by: John Ferlan <jferlan at redhat.com>

Double sign-off.

> ---
>  src/conf/storage_conf.c | 33 ++++++++++++++++++++++-----------
>  1 file changed, 22 insertions(+), 11 deletions(-)a

ACK, it looks much better now.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150415/405a4c50/attachment-0001.sig>

More information about the libvir-list mailing list