[libvirt] [PATCH] node: udev: Remove some redundant error reports

Martin Kletzander mkletzan at redhat.com
Wed Apr 15 13:06:00 UTC 2015


On Wed, Apr 15, 2015 at 02:54:12PM +0200, Peter Krempa wrote:
>All the called functions already report an error.
>---
> src/node_device/node_device_udev.c | 15 ++-------------
> 1 file changed, 2 insertions(+), 13 deletions(-)
>
>diff --git a/src/node_device/node_device_udev.c b/src/node_device/node_device_udev.c
>index 8c39e5f..1025e80 100644
>--- a/src/node_device/node_device_udev.c
>+++ b/src/node_device/node_device_udev.c
>@@ -213,9 +210,6 @@ static int udevGetDeviceSysfsAttr(struct udev_device *udev_device,
>     /* If this allocation is changed, the comment at the beginning
>      * of the function must also be changed. */
>     if (VIR_STRDUP(*attr_value, udev_value) < 0) {
>-        VIR_ERROR(_("Failed to allocate memory for sysfs attribute value for "
>-                    "sysfs attribute '%s' on device with sysname '%s'"),
>-                  attr_name, udev_device_get_sysname(udev_device));

Even though this might help in debugging if it were a VIR_DEBUG, it
doesn't make much sense since that happens only on OOM, so ACK.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150415/a10971c4/attachment-0001.sig>


More information about the libvir-list mailing list