[libvirt] [Xen-devel] [PATCH] libxl: initialize vfb defbools in libxlMakeVfb

Olaf Hering olaf at aepfle.de
Mon Apr 20 10:20:09 UTC 2015


On Mon, Apr 20, Ian Campbell wrote:

> If what you said were true then an assert would be a rather harsh
> overreaction to an application coding error.

Currently both libxl and libvirt are coded that way. Since the sdl code
path in libvirt was never executed the crash in libxlMakeVfbList was not
noticed.

So you are saying that an external user of libxl_device_vfb_init has to
call yet another function to initialize all defbool to give them either
true of false? Or should libxl_device_vfb_init call
libxl__device_vfb_setdefault directly?

Olaf




More information about the libvir-list mailing list