[libvirt] [PATCH v2] parallels: use SDK disks system names for paths

Dmitry Guryanov dguryanov at parallels.com
Mon Apr 20 17:01:55 UTC 2015


On 04/20/2015 12:56 PM, Nikolay Shirokovskiy wrote:
> For block devices SDK friendly name do not
> refer to block device path but rather some
> description while system name refer to
> device path.
>
> For ploop devices both names refer to
> image path.
>
> Thus system name is better choice.
>
> Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy at parallels.com>
> ---
>   src/parallels/parallels_sdk.c |    4 ++--
>   1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/parallels/parallels_sdk.c b/src/parallels/parallels_sdk.c
> index 72c1773..e1ba7cf 100644
> --- a/src/parallels/parallels_sdk.c
> +++ b/src/parallels/parallels_sdk.c
> @@ -485,13 +485,13 @@ prlsdkGetDiskInfo(PRL_HANDLE prldisk,
>           disk->device = VIR_DOMAIN_DISK_DEVICE_DISK;
>       }
>   
> -    pret = PrlVmDev_GetFriendlyName(prldisk, NULL, &buflen);
> +    pret = PrlVmDev_GetSysName(prldisk, NULL, &buflen);
>       prlsdkCheckRetGoto(pret, cleanup);
>   
>       if (VIR_ALLOC_N(buf, buflen) < 0)
>           goto cleanup;
>   
> -    pret = PrlVmDev_GetFriendlyName(prldisk, buf, &buflen);
> +    pret = PrlVmDev_GetSysName(prldisk, buf, &buflen);
>       prlsdkCheckRetGoto(pret, cleanup);
>   
Unfortunately, we should use PrlVmDev_GetFriendlyName for block devices 
and PrlVmDev_GetSysName for other types of disks.


>       if (virDomainDiskSetSource(disk, buf) < 0)




More information about the libvir-list mailing list