[libvirt] [PATCH] lxc: fix 2 issue around cpuset

lhuang lhuang at redhat.com
Tue Apr 21 05:33:47 UTC 2015


On 04/20/2015 10:04 PM, Ján Tomko wrote:
> On Fri, Apr 03, 2015 at 06:11:15PM +0800, Luyao Huang wrote:
>> There are two bugs in this function:
>>
>> 1. cannot start a vm with cpuset but without numatune settings
>>
>>   # virsh -c lxc:/// start helloworld
>>   error: Failed to start domain helloworld
>>   error: internal error: guest failed to start: Invalid value '1-3' for 'cpuset.mems': Invalid argument
>>
>> we don't free &mask after use it for virCgroupSetCpusetCpus() and
>> then virDomainNumatuneMaybeFormatNodeset() do not get a new &mask,
>> then we use it in virCgroupSetCpusetMems().
>>
>> 2. when start a lxc with numatune memory mode not strict
> I think these two fixes would be better pushed separately.
>
>>   # virsh -c lxc:/// start helloworld
>>   error: Failed to start domain helloworld
>>   error: internal error: guest failed to start: Unknown failure in libvirt_lxc startup
>>
>> We shouldn't set anything in cpuset.mems for these mode.
>>
>> Signed-off-by: Luyao Huang <lhuang at redhat.com>
>> ---
>>   src/lxc/lxc_cgroup.c | 6 +++++-
>>   1 file changed, 5 insertions(+), 1 deletion(-)
>>
> ACK, I've split the commit into two and pushed both.

Thanks a lot for your review and split.

>
> Jan

Luyao




More information about the libvir-list mailing list