[libvirt] [PATCH] libxl: initialize sdl.opengl defbool in libxlMakeVfb

Jim Fehlig jfehlig at suse.com
Fri Apr 24 20:35:45 UTC 2015

Commit bf32462b missed initializing sdl.opengl.  Without the
initialization, libvirtd will be terminated by an assert from libxl:

Assertion `!libxl_defbool_is_default(db)' failed.

Reported-by: Olaf Hering <olaf at aepfle.de>
Signed-off-by: Jim Fehlig <jfehlig at suse.com>

Perhaps bending the "trivial rule" a bit, but this patch is trivial
and should have been included in bf32462b.  I simply forgot to
add initialization of sdl.opengl before pushing bf32462b.  I'll push
this fix shortly.

 src/libxl/libxl_conf.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c
index 55bd21b..53f327b 100644
--- a/src/libxl/libxl_conf.c
+++ b/src/libxl/libxl_conf.c
@@ -1243,6 +1243,7 @@ libxlMakeVfb(virPortAllocatorPtr graphicsports,
             libxl_defbool_set(&x_vfb->sdl.enable, 1);
             libxl_defbool_set(&x_vfb->vnc.enable, 0);
+            libxl_defbool_set(&x_vfb->sdl.opengl, 0);
             if (VIR_STRDUP(x_vfb->sdl.display, l_vfb->data.sdl.display) < 0)
                 return -1;
             if (VIR_STRDUP(x_vfb->sdl.xauthority, l_vfb->data.sdl.xauth) < 0)

More information about the libvir-list mailing list