[libvirt] [PATCH] Cleanup srcdir usage

Martin Kletzander mkletzan at redhat.com
Mon Apr 27 13:10:53 UTC 2015


On Mon, Apr 27, 2015 at 11:23:23AM +0200, Michal Privoznik wrote:
>In a lot places we use path like this:
>
>  $(srcdir)/../src/....
>
>when in fact it can be:
>
>  $(top_srcdir)/src/
>
>Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
>---
> daemon/Makefile.am       | 12 ++++++------
> docs/Makefile.am         | 50 ++++++++++++++++++++++++------------------------
> src/Makefile.am          |  2 +-
> tests/schematestutils.sh |  2 +-
> 4 files changed, 33 insertions(+), 33 deletions(-)
>
>diff --git a/src/Makefile.am b/src/Makefile.am
>index 33ee723..17cf318 100644
>--- a/src/Makefile.am
>+++ b/src/Makefile.am
>@@ -20,7 +20,7 @@
> abs_builddir = $(shell pwd)
> abs_topbuilddir = $(shell cd .. && pwd)
> abs_srcdir = $(shell cd $(srcdir) && pwd)
>-abs_topsrcdir = $(shell cd $(srcdir)/.. && pwd)
>+abs_topsrcdir = $(shell cd $(top_srcdir) && pwd)
>

There are 5 places where we use topsrcdir (without the underscore),
top_srcdir is used everywhere else, could we fix that (in a follow-up,
for example), too?  That would be nice.

ACK to this one, though.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150427/3b8dfbdb/attachment-0001.sig>


More information about the libvir-list mailing list