[libvirt] [PATCH] Add missing linker flags for MinGW build

[Pavel Fedin]

 Hello!

> If it works, feel free to close the BZ or reply if it doesn't.

 It doesn't seem to work. And the error is, indeed:
--- cut ---
  CCLD     virnetserverclientmock.la
.libs/virnetserverclientmock_la-virnetserverclientmock.o: In function
`virNetSocketGetSELinuxContext':
C:\mingw64\msys\1.0\src\libvirt\tests/virnetserverclientmock.c:61: undefined
reference to `rpl_strdup'
.libs/virnetserverclientmock_la-virnetserverclientmock.o: In function
`virGetUserName':
C:\mingw64\msys\1.0\src\libvirt\tests/virnetserverclientmock.c:50: undefined
reference to `rpl_strdup'
.libs/virnetserverclientmock_la-virnetserverclientmock.o: In function
`virGetGroupName':
C:\mingw64\msys\1.0\src\libvirt\tests/virnetserverclientmock.c:55: undefined
reference to `rpl_strdup'
collect2.exe: error: ld returned 1 exit status
--- cut ---

 I will recheck.

Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia

> -----Original Message-----
> From: libvir-list-bounces at redhat.com [mailto:libvir-list-
> bounces at redhat.com] On Behalf Of Martin Kletzander
> Sent: Monday, April 27, 2015 6:07 PM
> To: Pavel Fedin
> Cc: libvir-list at redhat.com
> Subject: Re: [libvirt] [PATCH] Add missing linker flags for MinGW build
> 
> On Mon, Apr 27, 2015 at 05:40:28PM +0300, Pavel Fedin wrote:
> > Hello!
> >
> >> Thirdly, I wonder why you needed to add this, is gnulib really
> needed?
> >> is that because of those strdup()s in the file?  Why doesn't it fail
> >> with gcc then?
> >>
> >> Fourthly (is that even a word?), I'd ACK this and push it, but just
> >> please let me know whether GNULIB_LIBS is really needed here, so I
> >> know if I need to amend this or not.
> >
> > Yes, it is. Without GNULIB i get "undefined symbol" on...
> rtl_something...
> >Sorry, don't remember, but this clearly belongs to gnulib.
> >On Linux .so module can contain undefined symbols, which will be
> picked
> >up from surrounding binaries; on Windows it cannot. Hence this little
> problem.
> >
> 
> I already saw that with one build using MinGW (unfortunately I'm
> currently unable to use mingw compiler on my machine), so I sent
> another patch for that, added your SoB, but added it to LDADD instead
> of LDFLAGS as that's the right place to use it.
> 
> 
> Have a nice day,
> Martin