[libvirt] [PATCH] Bug 1086726: Reworked error messages in libvirt.c, libvirt-domain.c removing uses of __FUNCTION__, except one

[Noella Ashu]

Hello,


>
> We tend to do different formatting of commit messages. If you do 'git log'
> you'll immediately get a picture.


I see, forgot to check the previous commits first before doing mine. My
bad, will do better next time.


>
> The idea of the bug report is to do something like this:
>
> diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c
> index 4a45b9e..c39590d 100644
> --- a/src/libvirt-domain.c
> +++ b/src/libvirt-domain.c
> @@ -385,9 +385,7 @@ virDomainLookupByUUIDString(virConnectPtr conn, const
> char *uuidstr)
>      virCheckNonNullArgGoto(uuidstr, error);
>
>      if (virUUIDParse(uuidstr, uuid) < 0) {
> -        virReportInvalidArg(uuidstr,
> -                            _("uuidstr in %s must be a valid UUID"),
> -                            __FUNCTION__);
> +        virReportInvalidArg(uuidstr, "%s", _("invalid UUID"));
>          goto error;
>      }
>
> @@ -2180,9 +2178,8 @@ virDomainGetMemoryParameters(virDomainPtr domain,
>      if ((flags & VIR_DOMAIN_AFFECT_LIVE) &&
>          (flags & VIR_DOMAIN_AFFECT_CONFIG)) {
>          virReportInvalidArg(flags,
> -                            _("flags 'affect live' and 'affect config' in
> %s "
> -                              "are mutually exclusive"),
> -                            __FUNCTION__);
> +                            _("flags 'affect live' and 'affect config' "
> +                              "are mutually exclusive"));
>          goto error;
>      }
>      conn = domain->con


I see. I'll get it then, and re-send.

Thanks,

And so on.
Noella
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150401/05302cd6/attachment-0001.htm>