[libvirt] [PATCH 3/5] closeCallback is already lockable, initialize it as such

Martin Kletzander mkletzan at redhat.com
Mon Apr 13 14:33:50 UTC 2015


Luckily we are allocating structs as clean memory and
PTHREAD_MUTEX_INITIALIZER is "{ 0 }", so nothing happened, but it should
still be created as lockable object.

Signed-off-by: Martin Kletzander <mkletzan at redhat.com>
---
 src/datatypes.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/datatypes.c b/src/datatypes.c
index 0f535b4..dc024f8 100644
--- a/src/datatypes.c
+++ b/src/datatypes.c
@@ -1,7 +1,7 @@
 /*
  * datatypes.c: management of structs for public data types
  *
- * Copyright (C) 2006-2014 Red Hat, Inc.
+ * Copyright (C) 2006-2015 Red Hat, Inc.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
@@ -113,7 +113,7 @@ virGetConnect(void)
     if (!(ret = virObjectNew(virConnectClass)))
         return NULL;

-    if (!(ret->closeCallback = virObjectNew(virConnectCloseCallbackDataClass)))
+    if (!(ret->closeCallback = virObjectLockableNew(virConnectCloseCallbackDataClass)))
         goto error;

     if (virMutexInit(&ret->lock) < 0)
-- 
2.3.5




More information about the libvir-list mailing list