[libvirt] [PATCH v2 5/8] storage: Remove default from switch in virStoragePoolSourceFindDuplicate

John Ferlan jferlan at redhat.com
Mon Apr 13 21:21:09 UTC 2015


So that we can cover all the cases.

Signed-off-by: John Ferlan <jferlan at redhat.com>
---
 src/conf/storage_conf.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c
index bb89bb7..1fadff4 100644
--- a/src/conf/storage_conf.c
+++ b/src/conf/storage_conf.c
@@ -2458,7 +2458,7 @@ virStoragePoolSourceFindDuplicate(virConnectPtr conn,
 
         virStoragePoolObjLock(pool);
 
-        switch (pool->def->type) {
+        switch ((virStoragePoolType)pool->def->type) {
         case VIR_STORAGE_POOL_DIR:
             if (STREQ(pool->def->target.path, def->target.path))
                 matchpool = pool;
@@ -2544,7 +2544,12 @@ virStoragePoolSourceFindDuplicate(virConnectPtr conn,
         case VIR_STORAGE_POOL_DISK:
             matchpool = virStoragePoolSourceFindDuplicateDevices(pool, def);
             break;
-        default:
+        case VIR_STORAGE_POOL_MPATH:
+        case VIR_STORAGE_POOL_RBD:
+        case VIR_STORAGE_POOL_SHEEPDOG:
+        case VIR_STORAGE_POOL_GLUSTER:
+        case VIR_STORAGE_POOL_ZFS:
+        case VIR_STORAGE_POOL_LAST:
             break;
         }
         virStoragePoolObjUnlock(pool);
-- 
2.1.0




More information about the libvir-list mailing list