[libvirt] [PATCH] tools: improve the error info when fail to parse parameter --soft-limit of memtune
Ján Tomko
jtomko at redhat.com
Tue Apr 14 11:53:15 UTC 2015
On Tue, Apr 14, 2015 at 06:24:40PM +0800, Shanzhi Yu wrote:
> When set guest memory with a invalid parameter of --soft-limit, it posts weird error:
>
> $ virsh memtune r7 --hard-limit 20417224 --soft-limit 9007199254740992 --swap-hard-limit 35417224
The subject is too long, as well as this line.
> error: Unable to parse integer parameter 'NAME
>
> Change it to
>
> error: Unable to parse integer parameter soft-limit
>
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1211550
> Signed-off-by: Shanzhi Yu <shyu at redhat.com>
> ---
> tools/virsh-domain.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
> index 3e2c420..ebdf398 100644
> --- a/tools/virsh-domain.c
> +++ b/tools/virsh-domain.c
> @@ -8417,7 +8417,7 @@ cmdMemtune(vshControl *ctl, const vshCmd *cmd)
>
> #define PARSE_MEMTUNE_PARAM(NAME, FIELD) \
> if ((rc = vshMemtuneGetSize(cmd, NAME, &tmpVal)) < 0) { \
> - vshError(ctl, "%s", _("Unable to parse integer parameter 'NAME'")); \
> + vshError(ctl, _("Unable to parse integer parameter %s"), NAME); \
Indentation of the backlash is off.
ACK,
I have shortened the long lines, fixed the indentation and pushed the
patch.
Jan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150414/20ed2c13/attachment-0001.sig>
More information about the libvir-list
mailing list