[libvirt] [PATCH] virNetSocketNewConnectUNIX: Don't unlink(NULL)
John Ferlan
jferlan at redhat.com
Thu Apr 16 16:23:30 UTC 2015
On 04/16/2015 10:28 AM, Michal Privoznik wrote:
> There is a possibility that we jump onto error label with @lockpath
> still initialized to NULL. Here, the @lockpath should be unlink()-ed,
> but passing there a NULL is not a good idea. Don't do that. In fact,
> we should call unlink() only if we created the lock file successfully.
>
> Reported-by: John Ferlan <jferlan at redhat.com>
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
> src/rpc/virnetsocket.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
ACK (Coverity is happy too)
John
More information about the libvir-list
mailing list