[libvirt] [Xen-devel] [PATCH] libxl: initialize vfb defbools in libxlMakeVfb

[Olaf Hering]

On Mon, Apr 20, Ian Campbell wrote:

> On Fri, 2015-04-17 at 13:40 -0600, Jim Fehlig wrote:
> > On 04/17/2015 11:19 AM, Olaf Hering wrote:
> > > If the domU configu has sdl enabled libvirtd crashes:
> > > libvirtd[5158]: libvirtd: libxl.c:343: libxl_defbool_val: Assertion `!libxl_defbool_is_default(db)' failed.
> > 
> > The assertion seems harsh considering the offense...
> 
> libxl should be setting a default for this value if the application
> hasn't, by calling libxl__device_vfb_setdefault at some correct point.

This is an internal function. Its up to the caller of
libxl_device_vfb_init to initialize the defbool members.

Olaf