[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 02/15] util: Add virabstracts file for keeping abstract classes

On Tue, Apr 21, 2015 at 06:41:36PM +0200, Michal Privoznik wrote:
On 16.04.2015 16:46, Martin Kletzander wrote:
The first class in this file is going to be an abstract connection class
that holds a per-connection error inside.  virConnect will be the first
child class inheriting from this one.

This is a separate file because virerror.c is going to depend on it and
putting it into datatypes along with other connect classes would create
a dependency on datatypes from the util library.

Signed-off-by: Martin Kletzander <mkletzan redhat com>
 src/Makefile.am          |   3 +-
 src/libvirt_private.syms |   5 +++
 src/util/virabstracts.c  | 100 +++++++++++++++++++++++++++++++++++++++++++++++
 src/util/virabstracts.h  |  57 +++++++++++++++++++++++++++
 4 files changed, 164 insertions(+), 1 deletion(-)
 create mode 100644 src/util/virabstracts.c
 create mode 100644 src/util/virabstracts.h

You need to squash this in:

Not really, this patch is removed from the series as there is no need
for it.  But thanks a lot for having a look ;)

diff --git a/src/xen/xen_inotify.c b/src/xen/xen_inotify.c
index cd1e2df..9592de7 100644
--- a/src/xen/xen_inotify.c
+++ b/src/xen/xen_inotify.c
@@ -410,7 +410,7 @@ xenInotifyOpen(virConnectPtr conn,
    VIR_DEBUG("Building initial config cache");
    if (priv->useXenConfigCache &&
        xenXMConfigCacheRefresh(conn) < 0) {
-        VIR_DEBUG("Failed to enable XM config cache %s", conn->err.message);
+        VIR_DEBUG("Failed to enable XM config cache %s", conn->parent.err.message);
        return -1;


Attachment: signature.asc
Description: PGP signature

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]