[libvirt] [PATCH 1/4] tests: Add VIR_TEST_DEBUG and VIR_TEST_VERBOSE
Laine Stump
laine at laine.org
Thu Apr 23 19:11:09 UTC 2015
On 04/23/2015 02:19 PM, Cole Robinson wrote:
> To remove a bunch of TestGetDebug()/TestGetVerbose() checks
> ---
> tests/cputest.c | 34 ++++-----
> tests/jsontest.c | 48 +++++--------
> tests/nodeinfotest.c | 2 +-
> tests/qemuargv2xmltest.c | 15 ++--
> tests/qemuhelptest.c | 6 +-
> tests/qemuhotplugtest.c | 19 +++--
> tests/qemumonitortest.c | 24 +++----
> tests/qemuxml2argvtest.c | 14 ++--
> tests/qemuxmlnstest.c | 6 +-
> tests/securityselinuxlabeltest.c | 6 +-
> tests/statstest.c | 3 +-
> tests/testutils.c | 2 +-
> tests/testutils.h | 12 ++++
> tests/testutilslxc.c | 2 +-
> tests/testutilsqemu.c | 2 +-
> tests/utiltest.c | 30 +++-----
> tests/virbuftest.c | 60 +++++++---------
> tests/virhashtest.c | 152 +++++++++++++--------------------------
> tests/virpcitest.c | 4 +-
> tests/virportallocatortest.c | 35 ++++-----
> 20 files changed, 188 insertions(+), 288 deletions(-)
rather than make you crawl through all of this to find the comment -
testutils.h fails make syntax-check when cppi is installed, due to
improper indentation (you need to put a space between # and define).
It's also missing an update to the copyright date.
Other than that looks fine. Nice cleanup! ACK.
More information about the libvir-list
mailing list