[libvirt] [PATCH v4 6/6] tests: add machine-vmport-opt qemu test

Martin Kletzander mkletzan at redhat.com
Mon Apr 27 14:18:06 UTC 2015


On Tue, Apr 21, 2015 at 01:57:41PM +0200, Marc-André Lureau wrote:
>Check that the vmport feature is correctly used in qemu commande line.
>---
> .../qemuxml2argv-machine-vmport-opt.args           |  6 +++++
> .../qemuxml2argv-machine-vmport-opt.xml            | 28 ++++++++++++++++++++++
> tests/qemuxml2argvtest.c                           |  2 ++
> 3 files changed, 36 insertions(+)
> create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-machine-vmport-opt.args
> create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-machine-vmport-opt.xml
>

It would be nice if the different machine type had a failing test as
well, but that's not a hard requisite from my side.

>diff --git a/tests/qemuxml2argvdata/qemuxml2argv-machine-vmport-opt.args b/tests/qemuxml2argvdata/qemuxml2argv-machine-vmport-opt.args
>new file mode 100644
>index 0000000..ea1a11f
>--- /dev/null
>+++ b/tests/qemuxml2argvdata/qemuxml2argv-machine-vmport-opt.args
>@@ -0,0 +1,6 @@
>+LC_ALL=C PATH=/bin HOME=/home/test USER=test LOGNAME=test QEMU_AUDIO_DRV=none \
>+/usr/bin/qemu \
>+-S -machine pc,accel=tcg,vmport=off -m 214 -smp 1 -nographic \
>+-monitor unix:/tmp/test-monitor,server,nowait -no-acpi -boot c -usb \
>+-hda /dev/HostVG/QEMUGuest1 -net none -serial \
>+none -parallel none
>diff --git a/tests/qemuxml2argvdata/qemuxml2argv-machine-vmport-opt.xml b/tests/qemuxml2argvdata/qemuxml2argv-machine-vmport-opt.xml
>new file mode 100644
>index 0000000..671d3a9
>--- /dev/null
>+++ b/tests/qemuxml2argvdata/qemuxml2argv-machine-vmport-opt.xml
>@@ -0,0 +1,28 @@
>+<domain type='qemu'>
>+  <name>QEMUGuest1</name>
>+  <uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid>
>+  <memory unit='KiB'>219100</memory>
>+  <currentMemory unit='KiB'>219100</currentMemory>
>+  <vcpu placement='static'>1</vcpu>
>+  <os>
>+    <type arch='i686' machine='pc'>hvm</type>
>+    <boot dev='hd'/>
>+  </os>
>+  <features>
>+    <vmport state='off'/>
>+  </features>
>+  <clock offset='utc'/>
>+  <on_poweroff>destroy</on_poweroff>
>+  <on_reboot>restart</on_reboot>
>+  <on_crash>destroy</on_crash>
>+  <devices>
>+    <emulator>/usr/bin/qemu</emulator>
>+    <disk type='block' device='disk'>
>+      <source dev='/dev/HostVG/QEMUGuest1'/>
>+      <target dev='hda' bus='ide'/>
>+      <address type='drive' controller='0' bus='0' target='0' unit='0'/>
>+    </disk>
>+    <controller type='ide' index='0'/>
>+    <memballoon model='virtio'/>
>+  </devices>
>+</domain>
>diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c
>index acd6126..299d0af 100644
>--- a/tests/qemuxml2argvtest.c
>+++ b/tests/qemuxml2argvtest.c
>@@ -607,6 +607,8 @@ mymain(void)
>     DO_TEST_FAILURE("machine-core-on", QEMU_CAPS_MACHINE_OPT);
>     DO_TEST("machine-usb-opt", QEMU_CAPS_MACHINE_OPT,
>             QEMU_CAPS_MACHINE_USB_OPT);
>+    DO_TEST("machine-vmport-opt", QEMU_CAPS_MACHINE_OPT,
>+            QEMU_CAPS_MACHINE_VMPORT_OPT);
>     DO_TEST("kvm", QEMU_CAPS_MACHINE_OPT);
>     DO_TEST("boot-cdrom", NONE);
>     DO_TEST("boot-network", NONE);
>-- 
>2.1.0
>
>--
>libvir-list mailing list
>libvir-list at redhat.com
>https://www.redhat.com/mailman/listinfo/libvir-list
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150427/bfec019e/attachment-0001.sig>


More information about the libvir-list mailing list