[libvirt] [PATCH 1/6] storage: fs: Don't overwrite virDirCreate error

Cole Robinson crobinso at redhat.com
Mon Apr 27 20:48:39 UTC 2015


virDirCreate will give us fine grained details about what actually failed.
---
 src/storage/storage_backend_fs.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/src/storage/storage_backend_fs.c b/src/storage/storage_backend_fs.c
index 521dc70..51d6bb3 100644
--- a/src/storage/storage_backend_fs.c
+++ b/src/storage/storage_backend_fs.c
@@ -813,8 +813,6 @@ virStorageBackendFileSystemBuild(virConnectPtr conn ATTRIBUTE_UNUSED,
                             VIR_DIR_CREATE_ALLOW_EXIST |
                             (pool->def->type == VIR_STORAGE_POOL_NETFS
                             ? VIR_DIR_CREATE_AS_UID : 0))) < 0) {
-        virReportSystemError(-err, _("cannot create path '%s'"),
-                             pool->def->target.path);
         goto error;
     }
 
@@ -1055,8 +1053,6 @@ static int createFileDir(virConnectPtr conn ATTRIBUTE_UNUSED,
                             VIR_DIR_CREATE_FORCE_PERMS |
                             (pool->def->type == VIR_STORAGE_POOL_NETFS
                              ? VIR_DIR_CREATE_AS_UID : 0))) < 0) {
-        virReportSystemError(-err, _("cannot create path '%s'"),
-                             vol->target.path);
         return -1;
     }
 
-- 
2.3.6




More information about the libvir-list mailing list