[libvirt] [PATCH] conf: explicitly initialize 'cpumask' variable

Peter Krempa pkrempa at redhat.com
Tue Apr 28 07:21:46 UTC 2015


On Tue, Apr 28, 2015 at 08:30:30 +0400, Roman Bogorodskiy wrote:
> Build with clang fails with:
> 
>   CC       conf/libvirt_conf_la-domain_conf.lo
>   conf/domain_conf.c:13377:9: error: variable 'cpumask' is used
>   uninitialized whenever 'if' condition is true
>   [-Werror,-Wsometimes-uninitialized]
>       if (!(tmp = virXMLPropString(node, "cpuset"))) {
>                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> and many other similar errors regarding the 'cpuset' variable.
> 
> Fix by explicitly initializing it with NULL.
> ---

ACK, qualifies for both build-breaker and trivial rule.

Peter
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150428/2c593a28/attachment-0001.sig>


More information about the libvir-list mailing list