[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] [PATCHv2] iscsi: do not fail to stop a stopped pool

Just as we allow stopping filesystem pools when they were unmounted
externally, do not fail to stop an iscsi pool when someone else
closed the session externally.

Reported at:
v2: Do not report errors when returning success (use probe=true)
    refrain from making controversial claims in the commit message

 src/storage/storage_backend_iscsi.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/src/storage/storage_backend_iscsi.c b/src/storage/storage_backend_iscsi.c
index 197d333..9e2d01e 100644
--- a/src/storage/storage_backend_iscsi.c
+++ b/src/storage/storage_backend_iscsi.c
@@ -449,8 +449,13 @@ virStorageBackendISCSIStopPool(virConnectPtr conn ATTRIBUTE_UNUSED,
                                virStoragePoolObjPtr pool)
     char *portal;
+    char *session;
     int ret = -1;
+    if ((session = virStorageBackendISCSISession(pool, true)) == NULL)
+        return 0;
+    VIR_FREE(session);
     if ((portal = virStorageBackendISCSIPortal(&pool->def->source)) == NULL)
         return -1;

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]