[libvirt] [PATCH 0/2] qemu: Improve memory alignment handling and fix upcoming powerpc

Andrea Bolognani abologna at redhat.com
Mon Aug 3 09:02:49 UTC 2015


On Fri, 2015-07-31 at 16:49 +0200, Peter Krempa wrote:
> 
> Peter Krempa (2):
>   qemu: Make memory alignment helper more universal
>   qemu: ppc64: Align memory sizes to 256MiB
> 
>  src/qemu/qemu_domain.c                             | 33 
> ++++++++++++++++------
>  src/qemu/qemu_domain.h                             |  3 +-
>  src/qemu/qemu_hotplug.c                            |  4 +--
>  .../qemuxml2argv-pseries-cpu-compat.args           |  2 +-
>  4 files changed, 30 insertions(+), 12 deletions(-)

Looks okay overall and works as expected from my limited
testing on ppc64.

One thing, though: the domain XML is not updated with the
rounded-up value, which I think might be a little bit
confusing to the user. Any chance the rounding up could
be reflected there as well?

Cheers.

-- 
Andrea Bolognani
Software Engineer - Virtualization Team




More information about the libvir-list mailing list