[libvirt] [PATCH v11 0/5] nodeinfo: Add support for subcores

John Ferlan jferlan at redhat.com
Mon Aug 3 13:27:54 UTC 2015



On 07/30/2015 05:37 AM, Andrea Bolognani wrote:
> Only patch 1/5 has been updated, all the other patches
> are the same as v8:
> 
>   2/5 https://www.redhat.com/archives/libvir-list/2015-July/msg01045.html
>   3/5 https://www.redhat.com/archives/libvir-list/2015-July/msg01048.html
>   4/5 https://www.redhat.com/archives/libvir-list/2015-July/msg01049.html
>   5/5 https://www.redhat.com/archives/libvir-list/2015-July/msg01050.html
> 
> I'm including the full history below.
> 
> Cheers.
> 
> 
> Changes in v11:
> 
>   * don't declare variables only used inside a code block
>     guarded by #ifdef outside of said code block
> 
>   * use virBitmapNextSetBit() instead of going through
>     all possible index values and calling
>     virBitmapIsBitSet() for each one
> 
> Changes in v10:
> 
>   * don't attempt to close a file that wasn't opened
> 
>   * report a detailed error to help with diagnosis
> 
> Changes in v9:
> 
>   * take into account the fact that kvm might not be loaded
>     or even installed
> 
> Changes in v8:
> 
>   * shortened test names so that make dist doesn't
>     stop working again
> 
> Changes in v7:
> 
>   * rebased on top of master now that the series this one
>     builds on have been merged
> 
> Changes in v6:
> 
>   * updated to work on top of
> 
>       [PATCH v2 00/10] nodeinfo: Various cleanups
> 
> Changes in v5:
> 
>   * streamlined the logic used to decide whether the subcore
>     configuration is valid and moved it to a separate function
> 
>   * split the tests into separate commits for easier review and
>     to hopefully avoid having trouble with the list due to the
>     message size
> 
> Changes in v4:
> 
>   * removed a printf() statement
> 
>   * fixed typo in a commit message
> 
> Changes in v3:
> 
>   * the function to get the number of threads per subcore
>     has been moved to the from virarch.c, which deals with
>     architecture names only and is therefore not the right
>     place to read host configuration, to nodeinfo.c where
>     the rest of this stuff lives
> 
>   * said function has also been given a shorter name
> 
>   * the "valid subcore mode" boolean has been removed:
>     threads_per_subcore will be a positive number if
>     subcores should be taken into account, and if that's
>     not the case (x86 host, tainted configuration) it
>     will simply be zero, so now the code needs to keep
>     track of a single variable instead of two
> 
>   * the test case has been renamed to be more
>     descriptive
> 
>   * the test data has been cleaned up by removing all
>     cpu/cpu*/node* links, which prevented 'make dist'
>     from working due to recursive linking
> 
> 
> Andrea Bolognani (3):
>   tests: Add subcores1 nodeinfo test
>   tests: Add subcores2 nodeinfo test
>   tests: Add subcores3 nodeinfo test
> 
> Shivaprasad G Bhat (2):
>   nodeinfo: Fix output on PPC64 KVM hosts
>   tests: Prepare for subcore tests
> 
>  src/libvirt_private.syms                           |   1 +
>  src/nodeinfo.c                                     | 153 ++++++++++++++++++++-
>  src/nodeinfo.h                                     |   1 +
>  tests/Makefile.am                                  |   6 +
>  [...]
>  tests/nodeinfomock.c                               |  35 +++++
>  tests/nodeinfotest.c                               |   8 +-
>  1348 files changed, 2134 insertions(+), 6 deletions(-)
>  [...]
>  create mode 100644 tests/nodeinfomock.c
> 

Pulled in 2-5 from v8 series, rebuilt, checked, and pushed.

Tks,

John




More information about the libvir-list mailing list