[libvirt] [PATCH] virt drivers: show used memory as 0 when domain is inactive

Daniel P. Berrange berrange at redhat.com
Mon Aug 10 08:28:52 UTC 2015


On Fri, Aug 07, 2015 at 02:08:47PM -0600, Jim Fehlig wrote:
> Commit 1ce7c1d2 changed domainGetInfo to set virDomainInfoPtr->memory
> to 0 when domain is inactive, but only did this for the LXC and QEMU
> drivers. Make a similar change to the other virt drivers so they all
> behave the same.

I'm not really convinced that this is right in general. I think that
when a guest is shutoff, we should just report the balloon level as
the same as the max memory level. Changing it to report 0 is quite a
significant semantic change in our APIs too. IOW, I think we should
revert that change you quote.


Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|




More information about the libvir-list mailing list