[libvirt] [PATCH 3/6] admin: Drop 'internal.h' include from libvirt-admin.h

Martin Kletzander mkletzan at redhat.com
Tue Aug 11 08:22:57 UTC 2015


On Tue, Aug 11, 2015 at 09:58:58AM +0200, Erik Skultety wrote:
>This is a public library, it shouldn't include anything that is
>internal. Including the library in it's current state to an example
>application fails the preprocessor phase.
>---
> include/libvirt/libvirt-admin.h | 2 --
> 1 file changed, 2 deletions(-)
>

ACK as-is (independent of other patches, feel free to push this ASAP.

>diff --git a/include/libvirt/libvirt-admin.h b/include/libvirt/libvirt-admin.h
>index b3cfc93..9997cc2 100644
>--- a/include/libvirt/libvirt-admin.h
>+++ b/include/libvirt/libvirt-admin.h
>@@ -26,8 +26,6 @@
> #ifndef __VIR_ADMIN_H__
> # define __VIR_ADMIN_H__
>
>-# include "internal.h"
>-
> # ifdef __cplusplus
> extern "C" {
> # endif
>--
>2.4.3
>
>--
>libvir-list mailing list
>libvir-list at redhat.com
>https://www.redhat.com/mailman/listinfo/libvir-list
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150811/fcde4409/attachment-0001.sig>


More information about the libvir-list mailing list