[libvirt] [PATCH v3 13/20] cpu: Support multiple PVRs in the ppc64 driver

Andrea Bolognani abologna at redhat.com
Tue Aug 11 13:49:46 UTC 2015


On Tue, 2015-08-11 at 10:26 +0200, Jiri Denemark wrote:
> 
> > +        if (!virXPathBoolean("boolean(./@value)", ctxt) ||
> > +            virXPathULongHex("string(./@value)", ctxt, &pvr) < 0) 
> > {
> > +                virReportError(VIR_ERR_INTERNAL_ERROR,
> > +                               _("Missing or invalid PVR value in 
> > CPU model %s"),
> > +                               model->name);
> > +                goto ignore;
> 
> Wrong indentation, s/^    // in the 4 lines above. ACK once it's 
> fixed.

Good catch.

I've fixed the indentation and removed the unnecessary call
to virXPathBoolean(), as agreed, both here and in patch 15/20.

Cheers.

-- 
Andrea Bolognani
Software Engineer - Virtualization Team




More information about the libvir-list mailing list