[libvirt] [PATCH] nodedev: Fix gfeature size to be according to running kernel

Laine Stump laine at laine.org
Tue Aug 11 21:33:48 UTC 2015


On 08/11/2015 05:24 PM, Moshe Levi wrote:
>
>> Laine's patch is now pushed - I assume at least parts of this will be necessary
>> since there are reports of different GFEATURE_SIZE values...
> Ok, Do you want me to rebase my patch on top on this 
> http://libvirt.org/git/?p=libvirt.git;a=commit;h=bfaaa2b681018f3705bae17c001700a03f67d7c4 
> and fixing all Laine comments or to wait for the  cleanup patch you mention below?

I would say just rebase your patch on top of the simpler patch that I
pushed, and resend it; leave cleaning up the other nits that I found
until later (if even then). Parts of my "cleanup" had the effect of
causing a failure return any time the ioctl returned an error, which I
now see may not be the best course of action, so some of my proposed
changes are suspect at best :-)




More information about the libvir-list mailing list