[libvirt] [PATCH] domain: Fix crash if trying to live update disk <serial>

[Cole Robinson]

On 08/11/2015 05:32 PM, John Ferlan wrote:
> 
> 
> On 08/11/2015 05:28 PM, Cole Robinson wrote:
>> On 08/11/2015 05:25 PM, John Ferlan wrote:
>>>
>>>
>>> On 08/10/2015 07:33 PM, Cole Robinson wrote:
>>>> If you pass <disk><serial> XML to UpdateDevice, and the original device
>>>> didn't have a <serial> block, libvirtd crashes trying to read the original
>>>> NULL serial string.
>>>>
>>>> Use _NULLABLE string comparisons to avoid the crash. A couple other
>>>> properties needed the change too.
>>>> ---
>>>>  src/conf/domain_conf.c | 8 ++++----
>>>>  1 file changed, 4 insertions(+), 4 deletions(-)
>>>>
>>>
>>> Using STRNEQ_NULLABLE means you probably don't have to check the disk->*
>>> value either, right?
>>>
>>> ACK - with that adjustment...
>>>
>>
>> It would change the semantic a bit; if the orig disk has a <serial>, but not
>> the XML passed to UpdateDevice, libvirt would now error where previously it
>> wouldn't. It might make sense but I didn't want to change behavior
>>
>> - Cole
>>
> 
> OK - fair enough... right - time to quit for the day I guess ;-)
> 
> ACK to what's on list
> 

Thanks, pushed now

- Cole