[libvirt] [RFC] libvirt-admin: Mark symbols as local

[Martin Kletzander]

On Tue, Aug 11, 2015 at 09:24:59PM +0200, Guido Günther wrote:
>Otherwise we're leaking some 30+ symbols like
>
>   virAdmConnectClass
>   virAdmConnectNew

==========

>   virConnectClass
>   virConnectCloseCallbackDataClass
>   virDomainClass

These three are not related to libvirt-admin, they are leaked from
datatypes, I guess.  We need libvirt_admin_private.syms that will act
for admin the same way as libvirt_private.syms acts fr the libvirt
library.

>   ...
>
>I marked the one symbol needed by the deamon as
>LIBVIRT_ADMIN_PRIVATE_<VERSION> for now.
>---
>
>There's likely a better solution for xdr_admin_connect_open_args.

What I don't understand is how come there's a problem with xdr
structures.  Thanks for noticing, though, I'll look into it.

>Cheers,
> -- Guido
>
> src/libvirt_admin.syms | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
>diff --git a/src/libvirt_admin.syms b/src/libvirt_admin.syms
>index d9e3c0b..de4f1b8 100644
>--- a/src/libvirt_admin.syms
>+++ b/src/libvirt_admin.syms
>@@ -16,3 +16,12 @@ LIBVIRT_ADMIN_1.3.0 {
>         virAdmConnectClose;
>         virAdmConnectRef;
> };
>+
>+
>+LIBVIRT_ADMIN_PRIVATE_1.2.19 {
>+    global:
>+        xdr_admin_connect_open_args;
>+
>+    local:
>+        *;
>+};
>--
>2.1.4
>
>--
>libvir-list mailing list
>libvir-list at redhat.com
>https://www.redhat.com/mailman/listinfo/libvir-list
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150812/2c4238d5/attachment-0001.sig>