[libvirt] [PATCH v3 3/4] qemu: Keep numad hint after reboot

Ján Tomko jtomko at redhat.com
Thu Aug 13 12:49:34 UTC 2015


s/reboot/daemon restart/ ?

On Thu, Aug 13, 2015 at 10:18:33AM +0200, Martin Kletzander wrote:
> The numad hint stored in priv->autoNodeset is information that gets lost
> during daemon restart.  And because we would like to use that
> information in the future, we also need to save it in the status XML.
> For the sake of tests, we need to initialize nnumaCell_max to some
> value, so that the restoration doesn't fail in our test suite.  There is
> no need to fill in the actual numa cell data since the recalculating
> function virCapabilitiesGetCpusForNodemask() will not fail, it will just
> skip filling the data in the bitmap which we don't use in tests anyway.
> 
> Signed-off-by: Martin Kletzander <mkletzan at redhat.com>
> ---
>  src/qemu/qemu_domain.c  | 32 +++++++++++++++++++++++++++++++-
>  tests/qemuxml2xmltest.c |  3 ++-
>  tests/testutilsqemu.c   |  2 ++
>  3 files changed, 35 insertions(+), 2 deletions(-)

> @@ -805,15 +817,33 @@ qemuDomainObjPrivateXMLParse(xmlXPathContextPtr ctxt,
>      }
>      VIR_FREE(nodes);
> 
> +    if (!(caps = virQEMUDriverGetCapabilities(driver, false)))
> +        goto error;
> +
> +    if ((tmp = virXPathString("string(./numad/@nodeset)", ctxt))) {
> +        if (virBitmapParse(tmp, 0, &priv->autoNodeset,
> +                           caps->host.nnumaCell_max) < 0)
> +            goto error;
> +
> +        if (!(priv->autoCpuset = virCapabilitiesGetCpusForNodemask(caps,
> +                                                                   priv->autoNodeset)))
> +            goto error;
> +    }
> +    virObjectUnref(caps);
> +    caps = NULL;

This assignment seems redundant.

Jan

> +    VIR_FREE(tmp);
> +
>      return 0;
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150813/1847bb4a/attachment-0001.sig>


More information about the libvir-list mailing list