[libvirt] [PATCH libvirt master] interface type: add udp socket support

[Jonathan Toppins]

On 8/12/15 12:29 PM, Ján Tomko wrote:
> On Tue, Aug 11, 2015 at 12:30:03PM -0400, Jonathan Toppins wrote:
>> On 8/10/15 11:06 AM, Ján Tomko wrote:
>>>>
>>>> Signed-off-by: Jonathan Toppins <jtoppins at cumulusnetworks.com>
>>>> ---
>>>>    docs/formatdomain.html.in        | 17 ++++++++++++
>>>>    src/conf/domain_conf.c           | 56 +++++++++++++++++++++++++++++++++++++---
>>>>    src/conf/domain_conf.h           |  3 +++
>>>>    src/conf/netdev_bandwidth_conf.h |  1 +
>>>>    src/libxl/libxl_conf.c           |  1 +
>>>>    src/lxc/lxc_controller.c         |  1 +
>>>>    src/lxc/lxc_process.c            |  1 +
>>>>    src/qemu/qemu_command.c          | 12 +++++++++
>>>>    src/qemu/qemu_hotplug.c          |  1 +
>>>>    src/qemu/qemu_interface.c        |  2 ++
>>>>    src/uml/uml_conf.c               |  5 ++++
>>>>    src/xenconfig/xen_sxpr.c         |  1 +
>>>>    tools/virsh-domain.c             |  1 +
>>>>    13 files changed, 99 insertions(+), 3 deletions(-)
>>>
>>> Missing test cases for tests/qemuxml2argvtest.c and
>>> tests/qemuxml2xmltest.c.
>>
>> Didn't know about the unit test area, would be happy to add some unit
>> tests. Is there some text document describing how one runs these tests
>> and needs to set things up or should I just read a good example?
>>
>
> Running 'make check' and 'make syntax-check' should run most of them
> with no setup needed.
>
> (There are some tests that will be skipped if utilities like cppi or
> pdwtags are not found on the system)
>
> For an example, just take a look at some of the commits changing
> qemuxml2argvtest.c.
>
> The XML files in qemuxml2argvdata are automatically validated against
> the schema in docs/schemas/domain.rng by domainschematest. They are also
> used by both qemuxml2xmltest and qemuxml2argvtest as the source XML.
> (these tests need to be added to the C files by hand).
>
> The .args files are used by qemuxml2argvtest to check if the generated
> QEMU command line does not change.
>
>>>
>>>> diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
>>>> index c0a265a..95f7f5d 100644
>>>> --- a/docs/formatdomain.html.in
>>>> +++ b/docs/formatdomain.html.in
>>>> @@ -4165,6 +4165,23 @@
>>>>      </devices>
>>>>      ...</pre>
>>>>
>>>> +    <h5><a name="elementsNICSUDP">UDP unicast tunnel</a></h5>
>>>> +
>>>> +    <p>
>>>> +    A UDP unicast architecture provides a virtual network which enables
>>>> +    connections between Qemu instances using Qemu's UDP infrastructure.</p>
>>>> +
>>>
>>> It would be nice to document what the addresses mean, and mention that
>>> this is supported <span class="since">Since 1.2.19</span>.
>>
>> ack, do I need to add it after the description paragraph (<p></p>)?
>
> Before the end of the paragraph.

Thanks for the info, traveling today. Hope to get to this over the weekend.

-Jon