[libvirt] [PATCH 4/9] Add newDomain parameter to qemuDomainAssignAddresses
John Ferlan
jferlan at redhat.com
Thu Aug 13 23:28:36 UTC 2015
On 08/12/2015 10:52 AM, Ján Tomko wrote:
> To differentiate a new domain from an existing one.
> ---
> src/qemu/qemu_command.c | 5 ++++-
> src/qemu/qemu_command.h | 3 ++-
> src/qemu/qemu_driver.c | 22 +++++++++++-----------
> src/qemu/qemu_process.c | 6 +++---
> tests/qemuhotplugtest.c | 2 +-
> tests/qemuxml2argvtest.c | 2 +-
> tests/qemuxmlnstest.c | 2 +-
> 7 files changed, 23 insertions(+), 19 deletions(-)
>
Could have used a slightly beefier commit message...
I've looked ahead and see how it's used and it seems OK - although it's
too bad we couldn't have some way to know in the domain def to know this
domain has never been defined/created *and* saved in some manner. This
certainly works, just was thinking of a way to avoid another parameter
and perhaps a way that could be extensible in the future
ACK to what's here - unless this causes someone to think of something
different.
John
More information about the libvir-list
mailing list