[libvirt] [PATCH] qemu: fix the error cover issue in qemuDomainAddCgroupForThread

Luyao Huang lhuang at redhat.com
Fri Aug 14 06:59:54 UTC 2015


Just like commit 704cf06, the error already will be set in
virCgroup* function, and virCgroupAddTask will return -1,
so We will always report error "Operation not permitted"
in this place.

Signed-off-by: Luyao Huang <lhuang at redhat.com>
---
 src/qemu/qemu_driver.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index fa655b5..e0d7fa5 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -4606,9 +4606,6 @@ qemuDomainAddCgroupForThread(virCgroupPtr cgroup,
     /* Add pid/thread to the cgroup */
     rv = virCgroupAddTask(new_cgroup, pid);
     if (rv < 0) {
-        virReportSystemError(-rv,
-                             _("unable to add id %d task %d to cgroup"),
-                             idx, pid);
         virCgroupRemove(new_cgroup);
         goto error;
     }
-- 
1.8.3.1




More information about the libvir-list mailing list