[libvirt] [PATCH v2 8/9] tests: Use qemuProcessPrepareMonitorChr in qemuxmlnstest

[Martin Kletzander]

On Mon, Aug 24, 2015 at 10:32:43AM +0100, Daniel P. Berrange wrote:
>On Mon, Aug 17, 2015 at 12:16:49PM -0700, Martin Kletzander wrote:
>> The output of that function was not tested until now.  In order to keep
>> the paths in /tmp, the test driver config is "fixed" as well.
>>
>> Signed-off-by: Martin Kletzander <mkletzan at redhat.com>
>> ---
>>  .../qemuxmlns-qemu-ns-commandline-ns0.args            |  2 +-
>>  .../qemuxmlns-qemu-ns-commandline-ns1.args            |  2 +-
>>  .../qemuxmlnsdata/qemuxmlns-qemu-ns-commandline.args  |  2 +-
>>  .../qemuxmlns-qemu-ns-domain-commandline-ns0.args     |  2 +-
>>  .../qemuxmlns-qemu-ns-domain-commandline.args         |  2 +-
>>  tests/qemuxmlnsdata/qemuxmlns-qemu-ns-domain-ns0.args |  2 +-
>>  tests/qemuxmlnsdata/qemuxmlns-qemu-ns-domain.args     |  2 +-
>>  tests/qemuxmlnstest.c                                 | 19 +++++++++++++------
>>  8 files changed, 20 insertions(+), 13 deletions(-)
>
>ACK
>

Thanks for the review, should I keep it as a separate patch or squash
it into the previous one (I prefer the former)?  How about the
qemuxml2argvtest, do we want to modify that as well if the function is
already being tested here?  I'm referring to the original question in
the cover letter.

Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150824/c21beaaf/attachment-0001.sig>