[libvirt] [PATCH] network type ethernet not needs to be reconnected

[Laine Stump]

On 08/24/2015 06:15 AM, Vasiliy Tolstov wrote:
> 2015-08-22 18:33 GMT+03:00 Vasiliy Tolstov <v.tolstov at selfip.ru>:
>> libvirt docs says that network type ethernet not fully
>> managed by libvirt, so don't check for ip.
>> This fixes issue when no ip assigned to interface in libvirt domain xml
>> and somebody want to change link state of interface.
>
> And does it possible to add this (if patch ok) to upcoming libvirt release?
>

I've been looking back at the history of why this code was added in the
first place to make sure we're not inadvertently breaking something else.

It looks like originally that code did check that ipaddr hadn't changed
(when there was a single IP address), which wasn't needed but also
didn't hurt anything (since ipaddr would always be 0 for type='ethernet'
in the qemu driver. Then recently (commit aa2cc7) support for multiple
IP addresses with type='ethernet' was added (apparently for LXC, but
also added for openvz), any code that had touched ethernet.ipaddr was
changed to look at nips and the ip array instead, but the code that
replaced the unnecessary but innocuous check in qemu_hotplug.c was done
incorrectly. So the correct thing *is* to simply remove the check.

All of that is a long winded way of saying ACK. I'll push it in awhile.