[libvirt] [PATCH] Revert "LXC: show used memory as 0 when domain is not active"

[Eric Blake]

On 08/27/2015 04:38 PM, Jim Fehlig wrote:

>>>>> This reverts commit 1ce7c1d20cfd5afb26d2dbc88201085d52415d0e,
>>>>> which introduced a significant semantic change to the
>>>>> virDomainGetInfo() API. Additionally, the change was only
>>>>> made to 2 of the 15 virt drivers.
>>>>>

>>>> I guess we should probably do this in the stable branch too, since I
>>>> think it made it into the most recent release.
>>>>       
>>> Erm, the change is out for a while now:
>>>
>>> git desc 1ce7c1d20cfd5afb26d2dbc88201085d52415d0e
>>> v1.2.6-225-g1ce7c1d
>>>     
>>
>> Oh yes, so it is. I'm still inclined to say we should be reverting it as
>> I think it is wrong. The change was based on the misleading field name
>> shown by virsh. The info->memory field shows the current balloon target,
>> and conceptually this should be equal to the max memory if the ballooon
>> driver is not active. As such I think it should be equal to max memory
>> if shutoff too.
>>   
> 
> Yikes, I forgot to commit this before leaving for travel/vacation. Is it
> still ok to commit to master? And just to be clear, then cherry pick to
> 1.2.7-1.2.18 maint branches?

Yes, that sounds like the best way to handle it.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150827/2214803d/attachment-0001.sig>