[libvirt] [PATCH] qemu: fail on attempts to use <filterref> for non-tap network connections

[Daniel P. Berrange]

On Mon, Aug 10, 2015 at 02:09:42AM -0400, Laine Stump wrote:
> nwfilter uses iptables and ebtables, which only work properly on
> tap-based network connections (*not* on macvtap, for example), but we
> just ignore any <filterref> elements for other types of networks,
> potentially giving users a false sense of security.
> 
> This patch checks the network type and fails/logs an error if any
> domain <interface> has a <filterref> when the connection isn't using a
> tap device.
> 
> This resolves:
> 
>   https://bugzilla.redhat.com/show_bug.cgi?id=1180011

ACK


Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|