[libvirt] [PATCH] fix LSB part of virtlogd runlevel script

[Martin Kletzander]

On Tue, Dec 01, 2015 at 02:09:59PM +0000, Olaf Hering wrote:
>Currently pkg build of master branch fails:
>
>[  300s] + /usr/lib/rpm/brp-boot-scripts
>[  300s] E: File `virtlogd' is missing `Required-Start', please add even if empty!
>[  300s] W: File `virtlogd' is missing `Required-Stop', please add even if empty!
>[  300s] E: File `virtlogd' has empty `Default-Start', please specify default runlevel(s)!
>[  300s] ERROR: found one or more broken init or boot scripts, please fix them.
>[  300s]        For more information about LSB headers please read the manual
>[  300s]        page of of insserv by executing the command `man 8 insserv'.
>[  300s]        If you don't understand this, mailto=werner at suse.de
>[  300s] error: Bad exit status from /var/tmp/rpm-tmp.44965 (%install)
>
>Add the required tags, fix the existing tags.
>Use soft dependency "Should-Start" because virtlogd may work without network.
>

It must work without network, but it doesn't even have to be started
after network, so there is not even a weak dependency, IMO.

>Signed-off-by: Olaf Hering <olaf at aepfle.de>
>---
> src/logging/virtlogd.init.in | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
>diff --git a/src/logging/virtlogd.init.in b/src/logging/virtlogd.init.in
>index 1408236..cc03615 100644
>--- a/src/logging/virtlogd.init.in
>+++ b/src/logging/virtlogd.init.in
>@@ -5,8 +5,12 @@
> #

There's an invalid link in the header, it should be linked here:

http://refspecs.linuxfoundation.org/LSB_5.0.0/LSB-Core-generic/LSB-Core-generic/initscrcomconv.html

> ### BEGIN INIT INFO
> # Provides: virtlogd
>-# Default-Start:
>-# Default-Stop: 0 1 2 3 4 5 6
>+# Default-Start: 3 5
>+# Required-Start:
>+# Required-Stop:
>+# Should-Start: $network $remote_fs
>+# Should-Stop $network $remote_fs:

the colon should not be at the end, but rather after the keyword.  And
as I said, network should not be here.

But seeing this patch, we should also fix other init scripts, I believe.
I, personally, see only the same problem in
src/locking/virtlockd.init.in, but I didn't use the script you used.

>+# Default-Stop: 0 1 2 4 6
> # Short-Description: virtual machine log manager
> # Description: This is a daemon for managing logs
> #              of virtual machine consoles
>
>--
>libvir-list mailing list
>libvir-list at redhat.com
>https://www.redhat.com/mailman/listinfo/libvir-list
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20151202/910284dd/attachment-0001.sig>