[libvirt] [PATCH v2] fix LSB part of virtlogd runlevel script

Olaf Hering olaf at aepfle.de
Wed Dec 2 07:54:28 UTC 2015


Currently pkg build of master branch fails:

[  300s] + /usr/lib/rpm/brp-boot-scripts
[  300s] E: File `virtlogd' is missing `Required-Start', please add even if empty!
[  300s] W: File `virtlogd' is missing `Required-Stop', please add even if empty!
[  300s] E: File `virtlogd' has empty `Default-Start', please specify default runlevel(s)!
[  300s] ERROR: found one or more broken init or boot scripts, please fix them.
[  300s]        For more information about LSB headers please read the manual
[  300s]        page of of insserv by executing the command `man 8 insserv'.
[  300s]        If you don't understand this, mailto=werner at suse.de
[  300s] error: Bad exit status from /var/tmp/rpm-tmp.44965 (%install)

Add the required tags, fix the existing tags.
Use soft dependency "Should-Start" because virtlogd may work without network.

Signed-off-by: Olaf Hering <olaf at aepfle.de>
---
v2: fix colon in Should-stop

 src/logging/virtlogd.init.in | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/src/logging/virtlogd.init.in b/src/logging/virtlogd.init.in
index 1408236..dadc343 100644
--- a/src/logging/virtlogd.init.in
+++ b/src/logging/virtlogd.init.in
@@ -5,8 +5,12 @@
 #
 ### BEGIN INIT INFO
 # Provides: virtlogd
-# Default-Start:
-# Default-Stop: 0 1 2 3 4 5 6
+# Default-Start: 3 5
+# Required-Start:
+# Required-Stop:
+# Should-Start: $network $remote_fs
+# Should-Stop: $network $remote_fs
+# Default-Stop: 0 1 2 4 6
 # Short-Description: virtual machine log manager
 # Description: This is a daemon for managing logs
 #              of virtual machine consoles




More information about the libvir-list mailing list